There’s a few questions I have and some things I’ve been waffling on that I’m hoping you all can help with.
Thanks to @haesleinhuepf’s work on ROIs, the only remaining things that need to be implemented (with regards to ImageJ-OMERO) are line, polyline, point, and floating text. Once those are implemented there will be a roughly equivalent ImgLib2 ROI for each OMERO ROI.
It was brought up previously that there is a difference between a region and an annotation. As such, would it be beneficial to include an Annotations class? This class would function similarly to
GeomRegions, and would hopefully emphasize the separation between these two concepts. Something like:
*I was thinking it made sense to add calls to @haesleinhuepf’s RealBinary operators in
Regions, but if it doesn’t make sense to add them to
Regions please let me know.
And if I create an annotations class, what should be included as an annotation? I 100% agree that points and floating text are annotations, but I go back and forth on lines and polylines.
Are lines/polylines regions or annotations?
In previous ROI implementations it appears as though lines and polylines were regions. And in order to be considered within the region a point just needed to be within a certain distance from the line. So if we wanted to be consistent with previous versions, it would make sense to have lines and polylines be regions.
Additionally, it appears as though
RasterizedPolygonalChain are regions. To my understanding,
RasterizedPolygonalChain is a region which contains the discrete points along a closed polygonal chain and
PointCollection represents a region containing a set of discrete points. A closed polygonal chain is just several connected line segments, so in order for a polygonal chain to contain anything the individual line segments need to be able to contain points. And if that’s the case then lines and polylines can contain points and should be classified as regions. It just seems like if closed polygonal chains can be regions, then lines and polylines are closely enough related that they too should be considered regions. However, if
PointCollection are not intended to be regions or are some special case please let me know.
The counter to all of this being, that lines are infinitely thin and thus highly unlikely to contain points of interest in anything except 1D. And I go back and forth on lines/polylines as regions/annotations. What does everyone else think?
As mentioned above, it seems to me that they are intended to be regions but this seems contradictory to the idea that lines and points are not regions. If someone could please explain the intention of these classes to me, I would really appreciate it. Also should
GeomRegions contain methods for creating these (i.e.
It seems as though there is a naming convention in which each shape has a rasterized counterpart. So am I correct in assuming that I should add a RasterizedHyperRectangle and a RasterizedHyperEllipsoid class? And if this is the case why isn’t there a PolygonalChain class?
Sorry if some of those questions seem redundant, a few of them kind of piggy-back off one another. @ctrueden @dietzc @tpietzsch @haesleinhuepf please let me know your thoughts on the above. Additionally please feel free to let me know if you have any questions, concerns, or suggestions regarding this project.
Thank you very much,